gengliangwang commented on a change in pull request #33775:
URL: https://github.com/apache/spark/pull/33775#discussion_r692015542
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateExpressionsSuite.scala
##########
@@ -1161,18 +1161,19 @@ class DateExpressionsSuite extends SparkFunSuite with
ExpressionEvalHelper {
withSQLConf(SQLConf.TIMESTAMP_TYPE.key -> tsType.toString) {
val expected = expectedAnswer("2013-07-15 08:15:23.5")
- Seq(true, false).foreach { ansi =>
+ Seq(true).foreach { ansi =>
withSQLConf(SQLConf.ANSI_ENABLED.key -> ansi.toString) {
var makeTimestampExpr = MakeTimestamp(
Literal(2013), Literal(7), Literal(15), Literal(8), Literal(15),
- Literal(Decimal(BigDecimal(23.5), 8, 6)),
Some(Literal(ZoneId.systemDefault().getId)))
+ Literal(Decimal(BigDecimal(23.5), 16, 6)),
+ Some(Literal(ZoneId.systemDefault().getId)))
checkEvaluation(makeTimestampExpr, expected)
checkEvaluation(makeTimestampExpr.copy(year = Literal.create(null,
IntegerType)), null)
checkEvaluation(makeTimestampExpr.copy(month =
Literal.create(null, IntegerType)), null)
checkEvaluation(makeTimestampExpr.copy(day = Literal.create(null,
IntegerType)), null)
checkEvaluation(makeTimestampExpr.copy(hour = Literal.create(null,
IntegerType)), null)
checkEvaluation(makeTimestampExpr.copy(min = Literal.create(null,
IntegerType)), null)
- checkEvaluation(makeTimestampExpr.copy(sec = Literal.create(null,
DecimalType(8, 6))),
+ checkEvaluation(makeTimestampExpr.copy(sec = Literal.create(null,
DecimalType(16, 6))),
Review comment:
How about adding test for `DecimalType(8, 6)` in
https://github.com/apache/spark/pull/33787 as well ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
