ueshin commented on a change in pull request #33756:
URL: https://github.com/apache/spark/pull/33756#discussion_r692350907
##########
File path: python/docs/source/reference/pyspark.pandas/indexing.rst
##########
@@ -344,6 +345,7 @@ Time/date components
DatetimeIndex.is_leap_year
DatetimeIndex.daysinmonth
DatetimeIndex.days_in_month
+ DatetimeIndex.map
Review comment:
nit: I don't think we need to add here if we don't override it.
##########
File path: python/pyspark/pandas/missing/indexes.py
##########
@@ -117,13 +117,10 @@ class
MissingPandasLikeDatetimeIndex(MissingPandasLikeIndex):
to_pydatetime = _unsupported_function("to_pydatetime", cls="DatetimeIndex")
mean = _unsupported_function("mean", cls="DatetimeIndex")
std = _unsupported_function("std", cls="DatetimeIndex")
- map = _unsupported_function("map", cls="DatetimeIndex")
class MissingPandasLikeCategoricalIndex(MissingPandasLikeIndex):
-
- # Functions
- map = _unsupported_function("map", cls="CategoricalIndex")
+ pass
Review comment:
I thinks we can remove this and related tests in
`../tests/indexes/test_base.py` now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
