HeartSaVioR commented on a change in pull request #33763:
URL: https://github.com/apache/spark/pull/33763#discussion_r693948734
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/MicroBatchExecution.scala
##########
@@ -47,10 +47,14 @@ class MicroBatchExecution(
triggerClock, plan.outputMode, plan.deleteCheckpointOnStop) {
@volatile protected var sources: Seq[SparkDataStream] = Seq.empty
+ @volatile protected var wrappedSources: MutableMap[
+ SparkDataStream, FakeLatestOffsetSupportsTriggerAvailableNow] = new
+ MutableHashMap[SparkDataStream,
FakeLatestOffsetSupportsTriggerAvailableNow]()
private val triggerExecutor = trigger match {
case t: ProcessingTimeTrigger => ProcessingTimeExecutor(t, triggerClock)
- case OneTimeTrigger => OneTimeExecutor()
+ case OneTimeTrigger => OneBatchExecutor()
Review comment:
Ah OK. I agree that the executor can be separated from the trigger and
be generalized by itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
