tgravescs commented on a change in pull request #33812:
URL: https://github.com/apache/spark/pull/33812#discussion_r693978092
##########
File path: core/src/main/scala/org/apache/spark/status/LiveEntity.scala
##########
@@ -553,7 +553,7 @@ private class LiveRDDDistribution(exec: LiveExecutor) {
def toApi(): v1.RDDDataDistribution = {
if (lastUpdate == null) {
lastUpdate = new v1.RDDDataDistribution(
- weakIntern(exec.hostPort),
+ weakIntern(if (exec.hostPort != null) exec.hostPort else exec.host),
Review comment:
host starts out null as well so It seems like we should really check to
make sure both hostPort and host aren't null.
There is code in liveEntity that actually looks at hotspot:
> def hostname: String = if (host != null) host else
Utils.parseHostPort(hostPort)._1
hostPort is set in block manager added and host is set in executor added, I
guess order of those messages could be messed up or something weird happened
where we didn't get both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
