allisonwang-db commented on a change in pull request #33536:
URL: https://github.com/apache/spark/pull/33536#discussion_r694349947



##########
File path: core/src/main/scala/org/apache/spark/api/java/JavaUtils.scala
##########
@@ -89,7 +91,7 @@ private[spark] object JavaUtils {
                   mm.remove(k)
                   prev = None
                 case _ =>
-                  throw new UnsupportedOperationException("remove")

Review comment:
       Usually, non-user-facing errors can be identified by the exception type, 
for example, `IllegalStateException`, or by the code logic. Here it seems if 
`underlying` is not a mutable map, then the `remove` operation is not 
supported. This seems to be a develop-facing error.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to