MaxGekk commented on a change in pull request #33816:
URL: https://github.com/apache/spark/pull/33816#discussion_r694502921
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/finishAnalysis.scala
##########
@@ -119,3 +120,25 @@ case class ReplaceCurrentLike(catalogManager:
CatalogManager) extends Rule[Logic
}
}
}
+
+/**
+ * Replaces casts of special datetime strings by its date/timestamp values
+ * if the input strings are foldable.
Review comment:
Do you mean `ConstantFolding`? but it is an optimization rule. Could you
explain me, please, why do you think that placing "correctness" (analysis) rule
to an optimization rule (which can be disabled potentially w/o violating of
correctness) is good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
