allisonwang-db commented on a change in pull request #33802:
URL: https://github.com/apache/spark/pull/33802#discussion_r695089447
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
##########
@@ -173,7 +174,8 @@ trait CheckAnalysis extends PredicateHelper with
LookupCatalog {
case s: Star =>
withPosition(s) {
- throw
QueryCompilationErrors.invalidStarUsageError(operator.nodeName)
+ throw
QueryCompilationErrors.invalidStarUsageError(operator.nodeName,
+ conf.supportQuotedRegexColumnName)
Review comment:
Is this correct? Even if `supportQuotedRegexColumnName` is true, a
`Star` expression is not necessarily a regexp expression.
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
##########
@@ -3020,6 +3020,14 @@ class DataFrameSuite extends QueryTest
}
}
}
+
+ test("SPARK-36488: Regular expression expansion should fail with a
meaningful message") {
Review comment:
This test should be added in `AnalysisErrorSuite`. Also, could you add
another test for invalid star usage when `SUPPORT_QUOTED_REGEX_COLUMN_NAME` is
true?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
