itholic commented on a change in pull request #33817:
URL: https://github.com/apache/spark/pull/33817#discussion_r695330584
##########
File path: python/pyspark/pandas/tests/test_categorical.py
##########
@@ -448,10 +451,7 @@ def identity(x) -> ps.Series[psdf.b.dtype]: # type: ignore
def astype(x) -> ps.Series[dtype]:
return x.astype(dtype)
- if LooseVersion(pd.__version__) >= LooseVersion("1.3"):
- # TODO(SPARK-36367): Fix the behavior to follow pandas >= 1.3
- pass
- elif LooseVersion(pd.__version__) >= LooseVersion("1.2"):
+ if LooseVersion(pd.__version__) >= LooseVersion("1.2"):
Review comment:
Thanks! Just fixed tests for pandas 1.0, 1.1, 1.2 series.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
