bozhang2820 commented on a change in pull request #33763:
URL: https://github.com/apache/spark/pull/33763#discussion_r695428238
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/MicroBatchExecution.scala
##########
@@ -382,6 +413,23 @@ class MicroBatchExecution(
// Generate a map from each unique source to the next available offset.
val (nextOffsets, recentOffsets) = uniqueSources.toSeq.map {
+ case (s: FakeLatestOffsetSupportsTriggerAvailableNow, limit) =>
+ val originalSource = originalSources.getOrElse(s, throw new
IllegalStateException(
Review comment:
For that we would have to wrap sources in the logical plan... I think
having the wrapped sources only in `MicroBatchExecution.uniqueSources` is a
less intrusive and safer change. What do you think?
I will also remove `originalSource` mapping and get the original source
directly from the wrapped source instead.
##########
File path: sql/core/src/main/java/org/apache/spark/sql/streaming/Trigger.java
##########
@@ -20,6 +20,7 @@
import java.util.concurrent.TimeUnit;
import org.apache.spark.annotation.Evolving;
+import org.apache.spark.sql.execution.streaming.AvailableNowTrigger$;
Review comment:
Will do.
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FakeLatestOffsetMicroBatchStream.scala
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.streaming
+
+import org.apache.spark.sql.connector.read.{InputPartition,
PartitionReaderFactory}
+import org.apache.spark.sql.connector.read.streaming
+import org.apache.spark.sql.connector.read.streaming.MicroBatchStream
+
+/**
+ * This class wraps a [[MicroBatchStream]] and makes it supports
Trigger.AvailableNow.
+ *
+ * See [[FakeLatestOffsetSupportsTriggerAvailableNow]] for more details.
+ */
+class FakeLatestOffsetMicroBatchStream(source: MicroBatchStream)
+ extends FakeLatestOffsetSupportsTriggerAvailableNow(source) with
MicroBatchStream {
+
+ override def latestOffset(): streaming.Offset = source.latestOffset()
Review comment:
Makes sense. Will do.
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FakeLatestOffsetSupportsTriggerAvailableNow.scala
##########
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.streaming
+
+import org.apache.spark.internal.Logging
+import org.apache.spark.sql.connector.read.streaming.{MicroBatchStream,
ReadLimit, SparkDataStream, SupportsAdmissionControl,
SupportsTriggerAvailableNow}
+import org.apache.spark.sql.connector.read.streaming
+
+/**
+ * This class wraps a [[SparkDataStream]] and makes it support
Trigger.AvailableNow, by
+ * overriding its [[latestOffset]] method to always return the latest offset
when the method is
+ * first called. It is as if there is no new data coming in from the source
after the first
+ * [[latestOffset]] call.
+ */
+class FakeLatestOffsetSupportsTriggerAvailableNow(source: SparkDataStream)
Review comment:
I can do the rename here. For the places to wrap the sources let's have
the discussion in the other thread.
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/read/streaming/SupportsTriggerAvailableNow.java
##########
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.connector.read.streaming;
+
+import org.apache.spark.annotation.Evolving;
+
+/**
+ * An interface for streaming sources that supports running in
Trigger.AvailableNow mode, which
+ * will process all the available data at the beginning of the query in
(possibly) multiple batches.
+ *
+ * This mode will have better scalability comparing to Trigger.Once mode.
+ */
+@Evolving
Review comment:
Will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
