AngersZhuuuu commented on a change in pull request #33828:
URL: https://github.com/apache/spark/pull/33828#discussion_r695461797
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InsertIntoHadoopFsRelationCommand.scala
##########
@@ -162,23 +162,14 @@ case class InsertIntoHadoopFsRelationCommand(
}
}
- // For dynamic partition overwrite, FileOutputCommitter's output path is
staging path, files
- // will be renamed from staging path to final output path during commit
job
- val committerOutputPath = if (dynamicPartitionOverwrite) {
- FileCommitProtocol.getStagingDir(outputPath.toString, jobId)
- .makeQualified(fs.getUri, fs.getWorkingDirectory)
- } else {
- qualifiedOutputPath
- }
-
val updatedPartitionPaths =
FileFormatWriter.write(
sparkSession = sparkSession,
plan = child,
fileFormat = fileFormat,
committer = committer,
outputSpec = FileFormatWriter.OutputSpec(
- committerOutputPath.toString, customPartitionLocations,
outputColumns),
+ committer.outputPath.toString, customPartitionLocations,
outputColumns),
Review comment:
add ouputPath API make it more consistence?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
