imback82 commented on a change in pull request #33835:
URL: https://github.com/apache/spark/pull/33835#discussion_r695951421
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/v2ResolutionPlans.scala
##########
@@ -124,6 +124,16 @@ case class UnresolvedFunc(multipartIdentifier:
Seq[String]) extends LeafNode {
final override val nodePatterns: Seq[TreePattern] = Seq(UNRESOLVED_FUNC)
}
+/**
+ * Holds the name of a database object (table, view, namespace, function,
etc.) that is to be
+ * created and we need to determine the catalog to store it. It will be
resolved to
+ * [[ResolvedObjectName]] during analysis.
+ */
+case class UnresolvedObjectName(nameParts: Seq[String], isNamespace: Boolean)
extends LeafNode {
Review comment:
Hmm, if we need to store a different object name other than namespace,
will we create a new flag (e.g., `isFunction`)?
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/v2ResolutionPlans.scala
##########
@@ -124,6 +124,16 @@ case class UnresolvedFunc(multipartIdentifier:
Seq[String]) extends LeafNode {
final override val nodePatterns: Seq[TreePattern] = Seq(UNRESOLVED_FUNC)
}
+/**
+ * Holds the name of a database object (table, view, namespace, function,
etc.) that is to be
Review comment:
Will this also store table, view, and function names? We already have
`UnresolvedTable`, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
