c21 commented on a change in pull request #33842:
URL: https://github.com/apache/spark/pull/33842#discussion_r696287030
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFileFormat.scala
##########
@@ -118,7 +119,7 @@ class OrcFileFormat
override def supportBatch(sparkSession: SparkSession, schema: StructType):
Boolean = {
val conf = sparkSession.sessionState.conf
conf.orcVectorizedReaderEnabled && conf.wholeStageEnabled &&
- schema.length <= conf.wholeStageMaxNumFields &&
+ !WholeStageCodegenExec.isTooManyFields(conf, schema) &&
Review comment:
I am planning to create another PR for it to prevent future bug. Parquet
is not needed for now but good to have when
https://github.com/apache/spark/pull/33695 is merged. More context: ORC is
needed because we added support for nested column in branch 3.2 -
https://github.com/apache/spark/pull/31958 . Parquet is not needed because the
feature to support nested column has not been merged yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
