cloud-fan commented on a change in pull request #33822:
URL: https://github.com/apache/spark/pull/33822#discussion_r696582937
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
##########
@@ -1723,6 +1723,34 @@ class JDBCSuite extends QueryTest
Row("fred", 1) :: Nil)
}
+ test(
+ "SPARK-36574: pushDownPredicate=false should prevent push down filters to
JDBC data source") {
+ val df = spark.read.format("jdbc")
+ .option("Url", urlWithUserAndPass)
+ .option("dbTable", "test.people")
+ val df1 = df
+ .option("pushDownPredicate", false)
+ .load()
+ .filter("theid = 1")
+ .select("name", "theid")
+ val df2 = df
+ .load()
+ .select("name", "theid")
+
+ def getRowCount(df: DataFrame): Long = {
+ val queryExecution = df.queryExecution
+ val rawPlan = queryExecution.executedPlan.collect {
+ case p: DataSourceScanExec => p
+ } match {
+ case Seq(p) => p
+ case _ => fail(s"More than one PhysicalRDD found\n$queryExecution")
+ }
+ rawPlan.execute().count()
+ }
+
+ assert(getRowCount(df1) == getRowCount(df2))
Review comment:
nit: `assert(getRowCount(df1) == df2.count)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
