Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5897#discussion_r29807482
--- Diff:
unsafe/src/test/java/org/apache/spark/unsafe/bitset/BitSetSuite.java ---
@@ -39,6 +39,7 @@ public void basicOps() {
for (int i = 0; i < bs.capacity(); i++) {
Assert.assertFalse(bs.isSet(i));
}
+ Assert.assertFalse(bs.anySet());
--- End diff --
I still think that we should write a proper unit test for `anySet` that
will create a new bitset spanning multiple words, then set a single in each
word, then check that `anySet()` returns true. This test isn't sufficient
because it wouldn't have caught any of the bugs in earlier iterations of this
PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
