srowen commented on a change in pull request #33849:
URL: https://github.com/apache/spark/pull/33849#discussion_r697875786
##########
File path: repl/src/main/scala/org/apache/spark/repl/ExecutorClassLoader.scala
##########
@@ -160,7 +155,7 @@ class ExecutorClassLoader(
private def getClassFileInputStreamFromFileSystem(fileSystem: FileSystem)(
pathInDirectory: String): InputStream = {
- val path = new Path(directory, pathInDirectory)
+ val path = new Path(new Path(uri), pathInDirectory)
Review comment:
Can you explain a little more what inputs fail without this change?
##########
File path: repl/src/main/scala/org/apache/spark/repl/ExecutorClassLoader.scala
##########
@@ -55,13 +55,8 @@ class ExecutorClassLoader(
parent: ClassLoader,
userClassPathFirst: Boolean) extends ClassLoader(null) with Logging {
val uri = new URI(classUri)
- val directory = uri.getPath
-
val parentLoader = new ParentClassLoader(parent)
- // Allows HTTP connect and read timeouts to be controlled for testing /
debugging purposes
- private[repl] var httpUrlConnectionTimeoutMillis: Int = -1
Review comment:
I agree this is unused
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
