LuciferYang commented on a change in pull request #33848:
URL: https://github.com/apache/spark/pull/33848#discussion_r698124577
##########
File path: dev/deps/spark-deps-hadoop-3.2-hive-2.3
##########
@@ -53,10 +54,12 @@ datanucleus-core/4.1.17//datanucleus-core-4.1.17.jar
datanucleus-rdbms/4.1.19//datanucleus-rdbms-4.1.19.jar
derby/10.14.2.0//derby-10.14.2.0.jar
dropwizard-metrics-hadoop-metrics2-reporter/0.1.2//dropwizard-metrics-hadoop-metrics2-reporter-0.1.2.jar
+error_prone_annotations/2.5.1//error_prone_annotations-2.5.1.jar
Review comment:
If upgradingGuava version is not a good way, it seems that it is not
easy to fix this potential bug. I have manually verified that `Caffeine` does
not have this problem, but maybe we are not willing to accept it because
https://github.com/apache/spark/pull/33784#event-5190314002 .
So can we prevent users from using a problematic config by adding some
config value check?
##########
File path: dev/deps/spark-deps-hadoop-3.2-hive-2.3
##########
@@ -53,10 +54,12 @@ datanucleus-core/4.1.17//datanucleus-core-4.1.17.jar
datanucleus-rdbms/4.1.19//datanucleus-rdbms-4.1.19.jar
derby/10.14.2.0//derby-10.14.2.0.jar
dropwizard-metrics-hadoop-metrics2-reporter/0.1.2//dropwizard-metrics-hadoop-metrics2-reporter-0.1.2.jar
+error_prone_annotations/2.5.1//error_prone_annotations-2.5.1.jar
Review comment:
If upgradingGuava version is not a good way, it seems that it is not
easy to fix this potential bug. I have manually verified that `Caffeine` does
not have this problem, but maybe we are not willing to accept it because
https://github.com/apache/spark/pull/33784
So can we prevent users from using a problematic config by adding some
config value check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
