Peng-Lei commented on pull request #33339: URL: https://github.com/apache/spark/pull/33339#issuecomment-908988094
> Due to the way to register a catalog right now (by configs), I feel it's a bit hard to forbid invalid catalog names. If we do want to check the name, shall we update the config setting logic, match the catalog registration configs, and validate the catalog name there? so that we can fail it earlier. A little confused that it is reasonable that throw a invalid name exception when load a catalog(`catalog(name)`) with invalid name or `Catalogs.load` instead of use `SparkConf` to throw exception. I think maybe `SparkConf` should do common check with out `SQL` validition. Another thing: the changes of the testcase caused by the PR are actually reasonable. > so that we can fail it earlier. What's the point of fail it earlier? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
