Ngone51 commented on pull request #33872: URL: https://github.com/apache/spark/pull/33872#issuecomment-909844990
> Orthogonal to this bug, looks like we are not consistently locking on TaskSchedulerImpl when using taskIdToTaskSetManager - thoughts @Ngone51 ? Looks so. I found 2 places: https://github.com/apache/spark/blob/9b96b705b2cce403ba5339cd481648c19bec5147/core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala#L856 https://github.com/apache/spark/blob/9b96b705b2cce403ba5339cd481648c19bec5147/core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala#L371-L375 but both looks fine since `taskIdToTaskSetManager` itself is also a `ConcurrentHashMap`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
