mridulm commented on pull request #33536: URL: https://github.com/apache/spark/pull/33536#issuecomment-909809401
In general, atleast for core, unless it is a repeating pattern used atleast a few times and there is sufficient value in moving it out of the current throw site, let us not change it. For example,I am more persuaded by changes to `Py4JServer` in this PR - while the changes to `PythonHadoopUtil`, `BaseRRunner`, `PythonRDD` and so on do not add value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
