Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/5882#discussion_r29813576
--- Diff:
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisReceiver.scala
---
@@ -65,11 +69,14 @@ import
com.amazonaws.services.kinesis.clientlibrary.lib.worker.Worker
private[kinesis] class KinesisReceiver(
appName: String,
streamName: String,
- endpointUrl: String,
+ endpointUrl: String,
+ regionName: String,
+ awsAccessKeyId: String,
--- End diff --
If these can be null, then better to make these use
`Option[AWSCredentials]` where `case class AWSCredentials(accessKeyId: String,
secretKey)`. And place it at the end of the parameter list.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
