huaxingao commented on a change in pull request #33803: URL: https://github.com/apache/spark/pull/33803#discussion_r700651946
########## File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/filter/StringEndsWith.java ########## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.connector.expressions.filter; + +import org.apache.spark.annotation.Evolving; +import org.apache.spark.sql.connector.expressions.Expression; + +/** + * A filter that evaluates to `true` iff the field evaluates to + * a string that ends with `value`. + * + * @since 3.3.0 + */ +@Evolving +public final class StringEndsWith extends Filter { + private final Expression column; + private final String value; + + public StringEndsWith(Expression column, String value) { + this.column = column; + this.value = value; + } + + public Expression column() { return column; } + public String value() { return value; } + + @Override + public String toString() { return column.describe() + " ENDS WITH " + value; } Review comment: Fixed, thanks ########## File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/filter/And.java ########## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.connector.expressions.filter; + +import org.apache.spark.annotation.Evolving; +import org.apache.spark.sql.connector.expressions.Expression; +import org.apache.spark.sql.connector.expressions.NamedReference; + +/** + * A filter that evaluates to `true` iff both `left` and `right` evaluate to `true`. + * + * @since 3.3.0 + */ +@Evolving +public final class And extends Filter { + private final Filter left; + private final Filter right; + + public And(Filter left, Filter right) { + this.left = left; + this.right = right; + } + + public Filter left() { return left; } + public Filter right() { return right; } + + @Override + public String toString() { return left.describe() + " AND " + right.describe(); } Review comment: Fix. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
