HyukjinKwon commented on a change in pull request #33894:
URL: https://github.com/apache/spark/pull/33894#discussion_r700706756
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
##########
@@ -2333,7 +2333,12 @@ object QueryCompilationErrors {
}
def cannotModifyValueOfSparkConfigError(key: String): Throwable = {
- new AnalysisException(s"Cannot modify the value of a Spark config: $key")
+ new AnalysisException(
+ s"""
+ |Cannot modify the value of a Spark config: $key,
+ |please set spark.sql.legacy.setCommandRejectsSparkCoreConfs as 'false'
in
+ |order to make change value of Spark config: $key .
Review comment:
We actually documented this in migration guide. Let's don't show the
configuration in the error messages. We should ideally remove the legacy
configurations out in the future, and should discoruage users to rely on these.
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala
##########
@@ -319,6 +319,11 @@ class SQLConfSuite extends QueryTest with
SharedSparkSession {
assert(e2.message.contains("Cannot modify the value of a static config"))
}
+ test("Cannot modify the value of a Spark config") {
Review comment:
```suggestion
test("SPARK-36643: Cannot modify the value of a Spark config") {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
