liangz1 commented on a change in pull request #33853:
URL: https://github.com/apache/spark/pull/33853#discussion_r700706967
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
##########
@@ -2491,6 +2491,16 @@ class Dataset[T] private[sql](
}
}
+ /**
+ * Returns a new Dataset by updating an existing column with metadata.
+ *
+ * @group untypedrel
+ * @since 3.3.0
+ */
+ def withMetadata(columnName: String, metadata: Metadata): DataFrame = {
Review comment:
That would also work, but I prefer the current shorter version, since
the first param requires a column name, it's not likely for the users to be
confused about whether the metadata is for a column or something else. Also,
since this is syntax sugar, a shorter name would better justify the new API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
