c21 commented on a change in pull request #33899:
URL: https://github.com/apache/spark/pull/33899#discussion_r701222522
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala
##########
@@ -169,7 +169,8 @@ abstract class SparkStrategies extends
QueryPlanner[SparkPlan] {
}
private def checkHintNonEquiJoin(hint: JoinHint): Unit = {
- if (hintToShuffleHashJoin(hint) || hintToSortMergeJoin(hint)) {
+ if (hintToShuffleHashJoin(hint) || hintToPreferShuffleHashJoin(hint) ||
+ hintToSortMergeJoin(hint)) {
Review comment:
Yeah I am aware of this hint is internal only. I am more thinking
towards to catch and expose the bug where we apply `PREFER_SHUFFLE_HASH`
internally by mistake (e.g. for the added unit test query in
`JoinHintSuite.scala`). I feel it's no harm to add here and help catch more
bugs in the future. But if you guys think we should not add it, I can also
remove it. cc @cloud-fan .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
