MaxGekk commented on a change in pull request #33889:
URL: https://github.com/apache/spark/pull/33889#discussion_r703054116
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/intervalExpressions.scala
##########
@@ -598,6 +598,11 @@ trait IntervalDivide {
}
}
}
+
+ def divideByZeroCheckCodegen(expr: Expression, value: String): String =
expr.dataType match {
Review comment:
nit: Expression is too general as the first parameter, you could pass
`DataType`. Up to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
