HyukjinKwon commented on a change in pull request #33905:
URL: https://github.com/apache/spark/pull/33905#discussion_r703245225
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/util/QueryExecutionListener.scala
##########
@@ -41,19 +41,21 @@ trait QueryExecutionListener {
* A callback function that will be called when a query executed
successfully.
*
* @param funcName name of the action that triggered this query.
+ * @param executionId identifier of a query execution.
* @param qe the QueryExecution object that carries detail information like
logical plan,
* physical plan, etc.
* @param durationNs the execution time for this query in nanoseconds.
*
* @note This can be invoked by multiple different threads.
*/
@DeveloperApi
- def onSuccess(funcName: String, qe: QueryExecution, durationNs: Long): Unit
+ def onSuccess(funcName: String, executionId: Long, qe: QueryExecution,
durationNs: Long): Unit
Review comment:
we can't just add like this .. it breaks binary compatibility
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
