GitHub user jkbradley opened a pull request:
https://github.com/apache/spark/pull/5960
[SPARK-7429] [ml] Params cleanups
Params.setDefault taking a set of ParamPairs should be annotated with
varargs. I thought it would not work before, but it apparently does.
* **Q**: Do I need to modify the method to take 1 ParamPair, plus optional
more ParamPairs? I still am not sure when/why that is necessary:
```
@varargs
protected final def setDefault(firstParamPair: ParamPair, paramPairs:
ParamPair[_]*): this.type = {
```
CrossValidator.transform should call transformSchema since the underlying
Model might be a PipelineModel
CC: @mengxr
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jkbradley/spark params-cleanups
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5960.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5960
----
commit 118b158fac017a125dbc644597c4bf7eb58a0016
Author: Joseph K. Bradley <[email protected]>
Date: 2015-05-07T02:32:28Z
Params.setDefault taking a set of ParamPairs should be annotated with
varargs. I thought it would not work before, but it apparently does.
CrossValidator.transform should call transformSchema since the underlying
Model might be a PipelineModel
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
