cloud-fan commented on a change in pull request #33930:
URL: https://github.com/apache/spark/pull/33930#discussion_r704180322
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
##########
@@ -441,6 +456,24 @@ object BooleanSimplification extends Rule[LogicalPlan]
with PredicateHelper {
case Not(IsNull(e)) => IsNotNull(e)
case Not(IsNotNull(e)) => IsNull(e)
+
+ // Using Not(null) == null rules
+ case IsNull(Not(e)) => IsNull(e)
+ case IsNotNull(Not(e)) => IsNotNull(e)
Review comment:
shall we have a more general optimization in `NullPropagation`? It seems
like we can remove many expressions under `IsNull`/`IsNotNull` if they are
`NullIntolerant`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
