huaxingao commented on pull request #33803: URL: https://github.com/apache/spark/pull/33803#issuecomment-915785994
@cloud-fan per our off-line discussion, we will have the following: `BinaryComparison`: parent class for `EqualNullSafe`, `EqualTo`, `GreaterThan`, `GreaterThanOrEqual`, `LessThan`, `LessThanOrEqual`. `StringPredicate`: parent class for `StringContains`, `StringStartsWith` and `StringEndsWith`. `BinaryFilter`: parent class for `And`, `Or`. We will not have parent class for the rest of the filters. @viirya I have changed the parent class to be abstract. @sunchao I have addressed your comments as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
