kazuyukitanimura commented on a change in pull request #33930:
URL: https://github.com/apache/spark/pull/33930#discussion_r705929706
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
##########
@@ -441,6 +456,25 @@ object BooleanSimplification extends Rule[LogicalPlan]
with PredicateHelper {
case Not(IsNull(e)) => IsNotNull(e)
case Not(IsNotNull(e)) => IsNull(e)
+
+ // Using (Not(a) === b) == (a === Not(b)), (Not(a) <=> b) == (a <=>
Not(b)) rules
Review comment:
updated
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
##########
@@ -441,6 +456,25 @@ object BooleanSimplification extends Rule[LogicalPlan]
with PredicateHelper {
case Not(IsNull(e)) => IsNotNull(e)
case Not(IsNotNull(e)) => IsNull(e)
+
+ // Using (Not(a) === b) == (a === Not(b)), (Not(a) <=> b) == (a <=>
Not(b)) rules
+ // E.g. `EqualTo(Not(a), b)` where `b = Not(c)`, it will become
+ // `EqualTo(a, Not(b))` => `EqualTo(a, Not(Not(c)))` => `EqualTo(a, c)`
+ // In addition, `if canSimplifyNot(b)` checks if the optimization can
converge
+ // that avoids the situation two conditions are returning to each other.
+ case EqualTo(Not(a), b) if canSimplifyNot(b) => EqualTo(a, Not(b))
+ case EqualTo(a, Not(b)) if canSimplifyNot(a) => EqualTo(Not(a), b)
+ case EqualNullSafe(Not(a), b) if canSimplifyNot(b) => EqualNullSafe(a,
Not(b))
+ case EqualNullSafe(a, Not(b)) if canSimplifyNot(a) =>
EqualNullSafe(Not(a), b)
+
+ // Using (a =!= b) == (a === Not(b)), Not(a <=> b) == (a <=> Not(b))
rules
+ // E.g. Not(EqualTo(x, false)) => EqualTo(x, true)
Review comment:
updated
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
##########
@@ -797,6 +831,14 @@ object NullPropagation extends Rule[LogicalPlan] {
// a null literal.
case e: NullIntolerant if e.children.exists(isNullLiteral) =>
Literal.create(null, e.dataType)
+
+ // Using IsNull(e(inputs)) == IsNull(input1) or IsNull(input2) ... rules
+ // E.g. IsNull(Not(null)) == IsNull(null)
+ // E.g. IsNotNull(a === b) == And(IsNotNull(a), IsNotNull(b))
+ case IsNull(e: NullIntolerant) if !e.isInstanceOf[ExtractValue] &&
e.children.nonEmpty =>
Review comment:
updated the comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
