Github user duncanfinney commented on a diff in the pull request:
https://github.com/apache/spark/pull/5964#discussion_r29824376
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -1103,9 +1103,14 @@ class DAGScheduler(
// multiple tasks running concurrently on different executors). In
that case, it is possible
// the fetch failure has already been handled by the scheduler.
if (runningStages.contains(failedStage)) {
- logInfo(s"Marking $failedStage (${failedStage.name}) as failed "
+
- s"due to a fetch failure from $mapStage (${mapStage.name})")
- markStageAsFinished(failedStage, Some(failureMessage))
+ if (failedStage.attemptId - 1 > task.stageAttemptId) {
--- End diff --
This block is a little awkward. Being a little more explicit would be good
here.
Something like this:
```
//it is possible failure has already been handled by the scheduler.
val failureRequiresHandling = runningStages.contains(failedStage);
if (failureRequireHandling) {
val stageHasFailed = failedStage.attemptId - 1 > task.stageAttemptId;
if (stageHasFailed) {
...
}
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
