dongjoon-hyun commented on a change in pull request #33967:
URL: https://github.com/apache/spark/pull/33967#discussion_r706687201
##########
File path:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala
##########
@@ -1338,33 +1338,36 @@ abstract class HiveThriftServer2TestBase extends
SparkFunSuite with BeforeAndAft
process
}
+ ShutdownHookManager.addShutdownHook(stopThriftServer _)
ThreadUtils.awaitResult(serverStarted.future, SERVER_STARTUP_TIMEOUT)
}
private def stopThriftServer(): Unit = {
- // The `spark-daemon.sh' script uses kill, which is not synchronous, have
to wait for a while.
- Utils.executeAndGetOutput(
- command = Seq(stopScript),
- extraEnvironment = Map("SPARK_PID_DIR" -> pidDir.getCanonicalPath))
- Thread.sleep(3.seconds.toMillis)
+ if (pidDir.list.length > 0) {
Review comment:
nit.
```scala
- if (pidDir.list.length > 0) {
- if (pidDir.list.nonEmpty) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
