HyukjinKwon commented on a change in pull request #33934:
URL: https://github.com/apache/spark/pull/33934#discussion_r706730455
##########
File path: core/src/main/scala/org/apache/spark/deploy/PythonRunner.scala
##########
@@ -96,11 +96,13 @@ object PythonRunner {
try {
val process = builder.start()
- new RedirectThread(process.getInputStream, System.out, "redirect
output").start()
+ val redirectOutput = new RedirectThreadAndCatchErrorMsg(
+ process.getInputStream, System.out, "redirect output", "Traceback")
Review comment:
I think we should
1. remove `builder.redirectErrorStream`
2. find an easy way to merge both stderr & stdout to print out later
3. extract stderr from `process`
4. use it in exception message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
