mridulm commented on a change in pull request #33976:
URL: https://github.com/apache/spark/pull/33976#discussion_r707674542
##########
File path: core/src/test/scala/org/apache/spark/util/UtilsSuite.scala
##########
@@ -1509,10 +1509,10 @@ class UtilsSuite extends SparkFunSuite with
ResetSystemProperties with Logging {
assert(Utils.isPushBasedShuffleEnabled(conf) === false)
conf.set(SHUFFLE_SERVICE_ENABLED, true)
conf.set(SparkLauncher.SPARK_MASTER, "yarn")
- conf.set("spark.yarn.maxAttempts", "1")
+ conf.set("spark.yarn.maxAppAttempts", "1")
conf.set(SERIALIZER, "org.apache.spark.serializer.KryoSerializer")
assert(Utils.isPushBasedShuffleEnabled(conf) === true)
- conf.set("spark.yarn.maxAttempts", "2")
+ conf.set("spark.yarn.maxAppAttempts", "2")
Review comment:
While this test is no longer required (since we dont disable if multiple
attempts are present - like we used to earlier), give it is a minor change, it
is fine to include in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
