LuciferYang edited a comment on pull request #33977: URL: https://github.com/apache/spark/pull/33977#issuecomment-918751290
> IOUtils.closeQuietly can also receive consumer to define the behavior around IOException. (That said, JavaUtils.closeQuietly can be reimplemented as well leveraging IOUtils.closeQuietly) The default behavior is no-op (so no log message). I was just thinking about this. Should we define a `consumer` for logging, and use `IOUtils.closeQuietly(Closeable, Consumer<IOException>)` API where `JavaUtils.closeQuietly` is used. Of course, this is another thing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
