sunchao commented on a change in pull request #33969:
URL: https://github.com/apache/spark/pull/33969#discussion_r707968288
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetIOSuite.scala
##########
@@ -855,6 +855,12 @@ class ParquetIOSuite extends QueryTest with ParquetTest
with SharedSparkSession
}
}
+ test("SPARK-36726: test incorrect Parquet row group file offset") {
+ readParquetFile("test-data/malformed-file-offset.parquet") { df =>
+ assert(df.count() == 3650)
Review comment:
This is how `FileBasedDataSourceTest.readFile` is defined:
```scala
protected def readFile(path: String, testVectorized: Boolean = true)
(f: DataFrame => Unit): Unit = {
withSQLConf(vectorizedReaderEnabledKey -> "false") {
f(spark.read.format(dataSourceName).load(path.toString))
}
if (testVectorized) {
withSQLConf(vectorizedReaderEnabledKey -> "true") {
f(spark.read.format(dataSourceName).load(path.toString))
}
}
}
```
so to me it tests both paths. Did I miss anything?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
