dongjoon-hyun commented on a change in pull request #33995:
URL: https://github.com/apache/spark/pull/33995#discussion_r708572365
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -3826,32 +3826,43 @@ case class ArrayIntersect(left: Expression, right:
Expression) extends ArrayBina
if (TypeUtils.typeWithProperEquals(elementType)) {
(array1, array2) =>
if (array1.numElements() != 0 && array2.numElements() != 0) {
- val hs = new OpenHashSet[Any]
- val hsResult = new OpenHashSet[Any]
- var foundNullElement = false
+ val hs = new SQLOpenHashSet[Any]
+ val hsResult = new SQLOpenHashSet[Any]
+ val isNaN = SQLOpenHashSet.isNaN(elementType)
var i = 0
while (i < array2.numElements()) {
if (array2.isNullAt(i)) {
- foundNullElement = true
+ hs.addNull()
} else {
val elem = array2.get(i, elementType)
- hs.add(elem)
+ if (isNaN(elem)) {
+ hs.addNaN()
+ } else {
+ hs.add(elem)
+ }
}
i += 1
}
val arrayBuffer = new scala.collection.mutable.ArrayBuffer[Any]
i = 0
while (i < array1.numElements()) {
if (array1.isNullAt(i)) {
- if (foundNullElement) {
+ if (hs.containsNull() && !hsResult.containsNull()) {
arrayBuffer += null
- foundNullElement = false
+ hsResult.addNull()
}
} else {
val elem = array1.get(i, elementType)
- if (hs.contains(elem) && !hsResult.contains(elem)) {
- arrayBuffer += elem
- hsResult.add(elem)
+ if (isNaN(elem)) {
+ if (hs.containsNaN() && !hsResult.containsNaN()) {
+ arrayBuffer += elem
Review comment:
For this, let's wait a little bit for the decision at the first PR.
- https://github.com/apache/spark/pull/33955/files#r708570515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
