Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/552#issuecomment-42373182
Hi @ScrapCodes, I left more comments. The biggest thing is that the usage
seems to be deleted from many files, but we still want them around at least in
the comments as you have done in a few places. (I stopped pointing this out in
my comments half way through but you should verify this for all the files you
changed).
The other thing is that I'm not sure what `[<slices>]` vs `[slices]` mean.
If they both mean optional arguments, then I think it's more consistent to just
use the latter. This isn't introduced in this PR, but it would be good if you
could fix this.
Thanks again for doing all this tedious but important work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
