cloud-fan commented on a change in pull request #33958:
URL: https://github.com/apache/spark/pull/33958#discussion_r708805431
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/planning/ScanOperationSuite.scala
##########
@@ -57,7 +57,14 @@ class ScanOperationSuite extends SparkFunSuite {
test("Project which has the same non-deterministic expression with its child
Project") {
val project3 = Project(Seq(colA, colR), Project(Seq(colA, aliasR),
relation))
- assert(ScanOperation.unapply(project3).isEmpty)
+ project3 match {
Review comment:
I updated `ScanOperation` a little bit to follow `PhyiscalOperation`.
Basically, this pattern can always match. The returned plan can be different
according to which projects/filters get collected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
