viirya commented on a change in pull request #33958:
URL: https://github.com/apache/spark/pull/33958#discussion_r708944074
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
##########
@@ -78,25 +64,60 @@ object PhysicalOperation extends OperationHelper with
PredicateHelper {
* SELECT key AS c2 FROM t1 WHERE key > 10
* }}}
*/
- private def collectProjectsAndFilters(plan: LogicalPlan):
- (Option[Seq[NamedExpression]], Seq[Expression], LogicalPlan,
AttributeMap[Expression]) =
+ private def collectProjectsAndFilters(
+ plan: LogicalPlan,
+ alwaysInline: Boolean): IntermediateType = {
+ def empty: IntermediateType = (None, Nil, plan, AttributeMap.empty)
+
plan match {
- case Project(fields, child) if fields.forall(_.deterministic) =>
- val (_, filters, other, aliases) = collectProjectsAndFilters(child)
- val substitutedFields =
fields.map(substitute(aliases)).asInstanceOf[Seq[NamedExpression]]
- (Some(substitutedFields), filters, other,
collectAliases(substitutedFields))
+ case Project(fields, child) if !legacyMode ||
fields.forall(_.deterministic) =>
+ val (_, filters, other, aliases) = collectProjectsAndFilters(child,
alwaysInline)
+ if (legacyMode || canCollapseExpressions(fields, aliases,
alwaysInline)) {
+ val replaced = fields.map(replaceAliasButKeepName(_, aliases))
Review comment:
Is `replaceAliasButKeepName` exactly equal to previous `substitute`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
