viirya commented on a change in pull request #33975:
URL: https://github.com/apache/spark/pull/33975#discussion_r709327455
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/dynamicpruning/PartitionPruning.scala
##########
@@ -177,6 +177,29 @@ object PartitionPruning extends Rule[LogicalPlan] with
PredicateHelper with Join
}
}
+ /**
+ * Calculates a heuristic overhead of a logical plan. Normally it returns
the total
+ * size in bytes of all scan relations. We don't count in-memory relation
which uses
+ * only memory.
+ */
+ private def calculatePlanOverhead(plan: LogicalPlan): Float = {
+ val (cached, notCached) = plan.collectLeaves().partition(p => p match {
+ case _: InMemoryRelation => true
+ case _ => false
+ })
+ val scanOverhead = notCached.map(_.stats.sizeInBytes).sum.toFloat
+ val cachedOverhead = cached.map {
+ case m: InMemoryRelation if m.cacheBuilder.storageLevel.useDisk &&
+ !m.cacheBuilder.storageLevel.useMemory =>
+ m.stats.sizeInBytes.toFloat * 0.5
Review comment:
Per disk cache, I thought it could be treated as slightly light than
original table scan. But I'm okay to remove the 0.5 here too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
