dongjoon-hyun commented on a change in pull request #30701:
URL: https://github.com/apache/spark/pull/30701#discussion_r710272816



##########
File path: core/pom.xml
##########
@@ -66,7 +66,13 @@
     </dependency>
     <dependency>
       <groupId>org.apache.hadoop</groupId>
-      <artifactId>hadoop-client</artifactId>
+      <artifactId>${hadoop-client-api.artifact}</artifactId>

Review comment:
       I'll revise it.

##########
File path: core/pom.xml
##########
@@ -66,7 +66,13 @@
     </dependency>
     <dependency>
       <groupId>org.apache.hadoop</groupId>
-      <artifactId>hadoop-client</artifactId>
+      <artifactId>${hadoop-client-api.artifact}</artifactId>

Review comment:
       Hi, @LuciferYang . I agree with @xkrogen .
   
   When you use **without** `--am`, the other modules are the published 
SNAPSHOT poms and jars which is built with the default (Hadoop 3) configuration.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to