c21 commented on a change in pull request #33432:
URL: https://github.com/apache/spark/pull/33432#discussion_r710546681
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala
##########
@@ -158,14 +161,22 @@ private[hive] class HiveMetastoreCatalog(sparkSession:
SparkSession) extends Log
relation: HiveTableRelation,
options: Map[String, String],
fileFormatClass: Class[_ <: FileFormat],
- fileType: String): LogicalRelation = {
+ fileType: String,
+ isWrite: Boolean): LogicalRelation = {
val metastoreSchema = relation.tableMeta.schema
val tableIdentifier =
QualifiedTableName(relation.tableMeta.database,
relation.tableMeta.identifier.table)
val lazyPruningEnabled =
sparkSession.sqlContext.conf.manageFilesourcePartitions
val tablePath = new Path(relation.tableMeta.location)
val fileFormat = fileFormatClass.getConstructor().newInstance()
+ val bucketSpec = relation.tableMeta.bucketSpec
+ val (hiveOptions, hiveBucketSpec) =
+ if (isWrite) {
+ (options.updated(DDLUtils.HIVE_PROVIDER, "true"), bucketSpec)
Review comment:
@cloud-fan - updated. Added the reserved internal option name in
`BucketingUtils.optionNameForHiveCompatibleBucketWrite`.
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatDataWriter.scala
##########
@@ -271,17 +272,23 @@ abstract class BaseDynamicPartitionDataWriter(
val bucketIdStr =
bucketId.map(BucketingUtils.bucketIdToString).getOrElse("")
- // This must be in a form that matches our bucketing format. See
BucketingUtils.
- val ext = f"$bucketIdStr.c$fileCounter%03d" +
+ // The prefix and suffix must be in a form that matches our bucketing
format.
+ // See BucketingUtils.
Review comment:
@cloud-fan - updated.
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatDataWriter.scala
##########
@@ -271,17 +272,23 @@ abstract class BaseDynamicPartitionDataWriter(
val bucketIdStr =
bucketId.map(BucketingUtils.bucketIdToString).getOrElse("")
- // This must be in a form that matches our bucketing format. See
BucketingUtils.
- val ext = f"$bucketIdStr.c$fileCounter%03d" +
+ // The prefix and suffix must be in a form that matches our bucketing
format.
+ // See BucketingUtils.
+ val prefix = bucketId match {
Review comment:
@cloud-fan - updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
