Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5974#issuecomment-99830420
Ah, I see these checks mirror those in `countApproxDistinctByKey`. OK.
But they're slightly different than the essentially-equivalent check in
Python:
```
if relativeSD > 0.37:
raise ValueError("relativeSD should be smaller than 0.37")
```
I still favor it as it makes the Scala impls consistent. I wonder if Python
should just check the same thing since the docs don't say it rejects relativeSD
> 0.37
CC @davies
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
