yutoacts commented on a change in pull request #33988:
URL: https://github.com/apache/spark/pull/33988#discussion_r710756223
##########
File path: python/pyspark/testing/sqlutils.py
##########
@@ -243,6 +243,13 @@ def function(self, *functions):
for f in functions:
self.spark.sql("DROP FUNCTION IF EXISTS %s" % f)
+ @staticmethod
Review comment:
I moved get_values and assert_close and combined them as a static method
under SQLTestUtils as I don't see any function on the top-level statement.
Please let me know if it should be on the top level rather than a method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
