sadikovi commented on a change in pull request #34044: URL: https://github.com/apache/spark/pull/34044#discussion_r711885517
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaConverter.scala ########## @@ -266,7 +266,7 @@ class ParquetToSparkSchemaConverter( // Here we implement Parquet LIST backwards-compatibility rules. // See: https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#backward-compatibility-rules // scalastyle:on - private def isElementType(repeatedType: Type, parentName: String): Boolean = { + private[parquet] def isElementType(repeatedType: Type, parentName: String): Boolean = { Review comment: I am open to suggestions around how I can avoid changes in this file. I considered alternative approaches but they would require duplicating the code including the option of creating `isLegacyParquetList` method. This approach was the least intrusive, IMHO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
