sunchao commented on a change in pull request #33989:
URL: https://github.com/apache/spark/pull/33989#discussion_r712562388



##########
File path: sql/hive/pom.xml
##########
@@ -168,6 +128,18 @@
       <groupId>org.datanucleus</groupId>
       <artifactId>datanucleus-core</artifactId>
     </dependency>
+    <dependency>
+      <groupId>org.datanucleus</groupId>

Review comment:
       No, but I think it's a bit risky to relocate datanucleus. If you look at 
[HiveUtils](https://github.com/apache/spark/blob/master/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala#L518)
 there are places where class name from datanucleus is directly referenced. 
After relocation it may not function properly.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to