dongjoon-hyun commented on a change in pull request #34059:
URL: https://github.com/apache/spark/pull/34059#discussion_r713238592



##########
File path: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileSourceCodecSuite.scala
##########
@@ -56,6 +56,7 @@ class ParquetCodecSuite extends FileSourceCodecSuite {
   override def format: String = "parquet"
   override val codecConfigName: String = SQLConf.PARQUET_COMPRESSION.key
   // Exclude "lzo" because it is GPL-licenced so not included in Hadoop.
+  // TODO: test "brotli" if the system is not of ARM64 CPU architecture.

Review comment:
       Stephen casted -1 
   - 
https://lists.apache.org/thread.html/rb92464f98a2b15f2a66a7f2c6bea5f422eabfe00e4de0a17d4f0a20b%40%3Cdev.spark.apache.org%3E
   > I was going to -1 this because of the com.github.rdblue:brotli-codec:0.1.1 
dependency, which is not available on Maven Central, and therefore is not 
available from our repository manager (Nexus).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to