ulysses-you commented on a change in pull request #34065:
URL: https://github.com/apache/spark/pull/34065#discussion_r713663540
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala
##########
@@ -262,7 +262,7 @@ abstract class SparkStrategies extends
QueryPlanner[SparkPlan] {
// This join could be very slow or OOM
val buildSide = getSmallerSide(left, right)
Seq(joins.BroadcastNestedLoopJoinExec(
- planLater(left), planLater(right), buildSide, joinType,
nonEquiCond))
+ planLater(left), planLater(right), buildSide, joinType,
j.condition))
Review comment:
yes, smj only works with orderable key, but we have checked `orderable`
at analyzer side(at `BinaryComparison.checkInputDataTypes`). If we go in the
equi-join that means the key is orderable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
