ChenMichael commented on a change in pull request #34036:
URL: https://github.com/apache/spark/pull/34036#discussion_r714095456
##########
File path: sql/core/src/test/resources/sql-tests/results/explain-aqe.sql.out
##########
@@ -897,20 +897,20 @@ EXPLAIN FORMATTED
struct<plan:string>
-- !query output
== Physical Plan ==
-Execute CreateViewCommand (1)
- +- CreateViewCommand (2)
- +- Project (5)
- +- SubqueryAlias (4)
- +- LogicalRelation (3)
+Execute CreateViewCommand (5)
Review comment:
Ok, is it something that would be changed in a separate jira? It does
seem weird that numbering for most nodes are post-order, and then when it's a
node with inner children, it turns into pre-order
##########
File path: sql/core/src/test/resources/sql-tests/results/explain-aqe.sql.out
##########
@@ -897,20 +897,20 @@ EXPLAIN FORMATTED
struct<plan:string>
-- !query output
== Physical Plan ==
-Execute CreateViewCommand (1)
- +- CreateViewCommand (2)
- +- Project (5)
- +- SubqueryAlias (4)
- +- LogicalRelation (3)
+Execute CreateViewCommand (5)
Review comment:
Ok, is it something that would be changed in a separate jira though? It
does seem weird that numbering for most nodes are post-order, and then when
it's a node with inner children, it turns into pre-order
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]